Fix flaky test#385
Open
KrishaDeshkool wants to merge 2 commits into
Open
Conversation
KrishaDeshkool
force-pushed
the
fix_flaky_test
branch
2 times, most recently
from
268298b to
7e9975a
Compare
KrishaDeshkool
requested review from
LittleHuba,
bemerybmw,
castler,
crimson11,
hoe-jo and
limdor
as code owners
KrishaDeshkool
force-pushed
the
fix_flaky_test
branch
2 times, most recently
from
e3f2cdc to
15f4629
Compare
KrishaDeshkool
force-pushed
the
fix_flaky_test
branch
from
15f4629 to
5201764
Compare
Proxy destruction raced with the skeleton's StopOfferService async notification: the lola Proxy's FindServiceGuard callback iterates event_bindings_ and proxy_methods_ while the proxy is mid-destruction, causing a use-after-free. Mirror the skeleton's StopOfferService chain on the proxy side. The wrapper destructor calls Unsubscribe(), which tells each event/field to unsubscribe and then dispatches to the binding to stop its async source and clear its registration maps.
KrishaDeshkool
force-pushed
the
fix_flaky_test
branch
from
5201764 to
96a9ed1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue: #386